Ravi Nori has posted comments on this change.
Change subject: core: ImportVm test cleanup: Don't mock DAOs
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 372: }
Line 373: return true;
Line 374: }
Line 375:
Line 376: /** Validates that that the required cluster exists. */
Missed reformatting this one
Line 377: protected boolean validateVdsCluster() {
Line 378: List<VDSGroup> groups =
getVdsGroupDAO().getAllForStoragePool(getParameters().getStoragePoolId());
Line 379: for (VDSGroup group : groups) {
Line 380: if
(group.getId().equals(getParameters().getVdsGroupId())) {
--
To view, visit http://gerrit.ovirt.org/9626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d711cd8df8c0f8eccfe6b7838c16605829b2f6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
