Maor Lipchuk has posted comments on this change.
Change subject: core: Fix IndexOutOfBoundsException in plug FC disk
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
Line 67: }
Line 68:
Line 69: /**
Line 70: * Return the storage type which the Lun is related to. If the LUN
has no connections we assume that it is FCP
Line 71: * storage type, since FCP does not represent connections, if
other wise, we return the storage type of the first
fixed
Line 72: * connection
Line 73: *
Line 74: * @param lun
Line 75: * @return
Line 72: * connection
Line 73: *
Line 74: * @param lun
Line 75: * @return
Line 76: */
since the lun connections are being set explicitly, and not as part of the lun
fetch from the DB, I think that this method should reflect it also, other wise,
other might get confused and send a lun without setting its storage type.
method name - I tend to think that the method comment is good enough, but
suggestion are always welcome.
Method location - I think abstract disk is general enough since it is related
to all disk operations.
Line 77: private StorageType getLunStorageType(LUNs lun) {
Line 78: lun.setLunConnections(new
ArrayList<storage_server_connections>(getDbFacade()
Line 79: .getStorageServerConnectionDao()
Line 80: .getAllForLun(lun.getLUN_id())));
--
To view, visit http://gerrit.ovirt.org/9724
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6414445b9a74be299205ff7fc9a21d1388a29687
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
