Maor Lipchuk has posted comments on this change.
Change subject: core: Fix IndexOutOfBoundsException in plug FC disk
......................................................................
Patch Set 1: (5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
Line 71: * storage type, since FCP does not represent connections, if
other wise, we return the storage type of the first
Line 72: * connection
Line 73: *
Line 74: * @param lun
Line 75: * @return
Done
Line 76: */
Line 77: private StorageType getLunStorageType(LUNs lun) {
Line 78: lun.setLunConnections(new
ArrayList<storage_server_connections>(getDbFacade()
Line 79: .getStorageServerConnectionDao()
Line 72: * connection
Line 73: *
Line 74: * @param lun
Line 75: * @return
Line 76: */
Done
Line 77: private StorageType getLunStorageType(LUNs lun) {
Line 78: lun.setLunConnections(new
ArrayList<storage_server_connections>(getDbFacade()
Line 79: .getStorageServerConnectionDao()
Line 80: .getAllForLun(lun.getLUN_id())));
....................................................
Commit Message
Line 5: CommitDate: 2012-12-04 19:12:03 +0200
Line 6:
Line 7: core: Fix IndexOutOfBoundsException in plug FC disk
Line 8:
Line 9: attach detach and plug disk throws an exception of index out of bounds
done, used Attach/Detach
Line 10: exception.
Line 11: The reason for that is that the LUN FC which the disk is related to
does not contains any
Line 12: connections in it, compared to ISCSI lun which must have connections
Line 13: related to it.
Line 7: core: Fix IndexOutOfBoundsException in plug FC disk
Line 8:
Line 9: attach detach and plug disk throws an exception of index out of bounds
Line 10: exception.
Line 11: The reason for that is that the LUN FC which the disk is related to
does not contains any
Done
Line 12: connections in it, compared to ISCSI lun which must have connections
Line 13: related to it.
Line 14:
Line 15: The proposed fix is to use FCP storage type if the LUN does not contain
Line 8:
Line 9: attach detach and plug disk throws an exception of index out of bounds
Line 10: exception.
Line 11: The reason for that is that the LUN FC which the disk is related to
does not contains any
Line 12: connections in it, compared to ISCSI lun which must have connections
Done.
Line 13: related to it.
Line 14:
Line 15: The proposed fix is to use FCP storage type if the LUN does not contain
Line 16: any connections in it.
--
To view, visit http://gerrit.ovirt.org/9724
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6414445b9a74be299205ff7fc9a21d1388a29687
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
