Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler.setDiskAlias early return
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 110: }
Line 111:
Line 112: public static boolean setDiskAlias(BaseDisk disk, VM vm) {
Line 113: if (disk == null) {
Line 114: log.errorFormat("Disk object is null");
Good point, but in a different patch.
Line 115: return false;
Line 116: }
Line 117:
Line 118: String vmName = "";
--
To view, visit http://gerrit.ovirt.org/9658
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69cb7b17e97c86f14eaf64f751183bb5d1b0812a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
