Daniel Erez has posted comments on this change. Change subject: core: ImagesHandler.setDiskAlias early return ......................................................................
Patch Set 7: Looks good to me, approved (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java Line 121: vmName = vm.getVmName(); Line 122: count = vm.getDiskMapCount() + 1; Line 123: } Line 124: disk.setDiskAlias(getSuggestedDiskAlias(disk, vmName, count)); Line 125: return true; Is the block indentation correct? Line 126: } Line 127: Line 128: /** Line 129: * Retrieve disk alias name, if the alias name is null returns the default alias name. -- To view, visit http://gerrit.ovirt.org/9658 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69cb7b17e97c86f14eaf64f751183bb5d1b0812a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
