Eli Mesika has posted comments on this change. Change subject: engine: Restrict viewable networks by the User ......................................................................
Patch Set 5: (1 inline comment) .................................................... File backend/manager/dbscripts/create_views.sql Line 1431: AND network.name = vm_interface_view.network_name; Line 1432: Line 1433: -- Permissions on Networks Line 1434: -- The user has permissions on the Network directly Line 1435: CREATE OR REPLACE VIEW user_network_permissions_view_base (entity_id, granted_id) Did we test that for large systems ? We have now some problems regarding the performance of such queries and even tough this is not connected directly to this patch , I think that we will be forced to change the approach we check permissions and cache the permissions since this is a slowly changed data .... Line 1436: AS Line 1437: SELECT object_id, ad_element_id Line 1438: FROM permissions_view Line 1439: WHERE object_type_id = 20 AND role_type = 2 -- To view, visit http://gerrit.ovirt.org/9545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I542e687da8f51dd83e66d813c769275736abc114 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Muli Salem <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
