Mike Kolesnik has posted comments on this change. Change subject: engine: Restrict viewable networks by the User ......................................................................
Patch Set 9: (1 inline comment) Basically +2, 1 tiny comment .................................................... File backend/manager/dbscripts/create_views.sql Line 1450: ON network_cluster.cluster_id = vm_templates_view.vds_group_id Line 1451: INNER JOIN network Line 1452: ON network.id = network_cluster.network_id Line 1453: INNER JOIN permissions_view ON object_id = vm_interface_view.vmt_guid Line 1454: WHERE network.name = vm_interface_view.network_name This can be a part of the inner join with the network as it is a join logic Line 1455: AND object_type_id = 4 AND role_type = 2 Line 1456: -- Or the user has permissions on system Line 1457: UNION ALL Line 1458: SELECT network_id, ad_element_id -- To view, visit http://gerrit.ovirt.org/9545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I542e687da8f51dd83e66d813c769275736abc114 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Muli Salem <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
