Maor Lipchuk has posted comments on this change. Change subject: core: introducing OvfAutoUpdate ......................................................................
Patch Set 19: (3 inline comments) please fix TWS .................................................... File backend/manager/dbscripts/upgrade/03_02_1550_add_vm_generation_columns.sql Line 9: ); Line 10: Line 11: INSERT INTo vm_ovf_generations Line 12: (SELECT vm.vm_guid, sp.id Line 13: FROM vm_static vm ,storage_pool sp, vds_groups vg Please remove TWS Line 14: WHERE vg.storage_pool_id = sp.id AND vm.vds_group_id = vg.vds_group_id); Line 15: Line 16: -- Only pre-existing vms should have ovf_generation set to 1, so after we added Line 17: -- the pre existing vms, the default should be 0. .................................................... File backend/manager/dbscripts/vms_sp.sql Line 470: AS $procedure$ Line 471: DECLARE Line 472: curs CURSOR FOR SELECT vms.vm_guid FROM vm_static vms Line 473: WHERE vms.vds_group_id IN (SELECT v.vds_group_id FROM vds_groups v, storage_pool sp Line 474: WHERE sp.id=v_storage_pool_id AND v.storage_pool_id = sp.id) Please change view alias v for vds_groups. v.storage_pool_id and v_storage_pool_id are very similar and could be confusing Line 475: ORDER BY vm_guid; Line 476: id UUID; Line 477: BEGIN Line 478: OPEN curs; .................................................... Commit Message Line 5: CommitDate: 2012-12-13 11:45:48 +0200 Line 6: Line 7: core: introducing OvfAutoUpdate Line 8: Line 9: VM/template configurations (including disks info) are stored on the s/template/Template Line 10: master storage domain for backup purposes and in order to provide the Line 11: abillity to run VMs without having a running engine/db. Currently OVF Line 12: update is done synchronously when performing various operations on Line 13: VMs/templates - update, save, adding/removing a disk, etc. What's more, -- To view, visit http://gerrit.ovirt.org/9328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b5132300fb1f1fd94f771cab15efe5246dbeca8 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: liron aravot <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
