Allon Mureinik has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
......................................................................
Patch Set 20: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
Line 61: VdsFenceOptionTypes,
Line 62: ServerCPUList,
Line 63: SupportedClusterLevels(ConfigAuthType.User),
Line 64: OvfUpdateIntervalInMinutes,
Line 65: OvfItemsCountPerUpdate,
hmm.. fair enough :-)
The question should be "is it plausible for an admin to change them?" (e.g., if
instructed to do so by GSS).
Seems plausible, agree.
Line 66: ProductRPMVersion(ConfigAuthType.User),
Line 67: RhevhLocalFSPath,
Line 68: CustomPublicConfig_AppsWebSite(ConfigAuthType.User),
Line 69: DocsURL(ConfigAuthType.User),
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAODbFacadeImpl.java
Line 23: */
Line 24: @SuppressWarnings("synthetic-access")
Line 25: public class StoragePoolDAODbFacadeImpl extends BaseDAODbFacade
implements StoragePoolDAO {
Line 26:
Line 27: private static final class StoragePoolRawMapper implements
ParameterizedRowMapper<storage_pool> {
why not just do it properly, and rebase this change on top of a full-fledged
mapper cleanup change?
Line 28: @Override
Line 29: public storage_pool mapRow(ResultSet rs, int rowNum)
Line 30: throws SQLException {
Line 31: storage_pool entity = new storage_pool();
--
To view, visit http://gerrit.ovirt.org/9328
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b5132300fb1f1fd94f771cab15efe5246dbeca8
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
