Arik Hadas has posted comments on this change.

Change subject: restapi,engine: fix usb mapping on update vm call
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/UsbResourceUtils.java
Line 5: import org.ovirt.engine.core.common.businessentities.UsbPolicy;
Line 6: import org.ovirt.engine.core.common.businessentities.VDSGroup;
Line 7: import org.ovirt.engine.core.compat.Version;
Line 8: 
Line 9: public class UsbResourceUtils {
There is no backend calls in this util indeed, but in order to pass the 
VDSGroup instance to this util, the caller invokes backend.RunQuery to get it 
(at BackendTemplateResource#lookupCluster for example)
Line 10:     public static UsbPolicy getUsbPolicyOnCreate(Usb usb, VDSGroup 
vdsGroup) {
Line 11:         UsbPolicy usbPolicy = null;
Line 12:         if (usb == null || !usb.isSetEnabled() || !usb.isEnabled()) {
Line 13:             usbPolicy = UsbPolicy.DISABLED;


--
To view, visit http://gerrit.ovirt.org/9792
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If74bf6ede2fc0f932db8dfcd7951b6bcf90b7744
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to