Ayal Baron has posted comments on this change.
Change subject: core: ImportVm test cleanup: VM name generation
......................................................................
Patch Set 10: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
Line 28: @ClassRule
Line 29: public static MockConfigRule mcr = new MockConfigRule();
Line 30:
Line 31: @Rule
Line 32: public RandomUtilsSeedingRule rusr = new RandomUtilsSeedingRule();
where is rusr used?
Line 33:
Line 34: @Test
Line 35: @Ignore
Line 36: public void insufficientDiskSpace() {
Line 103:
Line 104: /**
Line 105: * Checking that other fields in
Line 106: * {@link
org.ovirt.engine.core.common.businessentities.VmStatic.VmStatic}
Line 107: * aren't get validated in import or import as cloned.
s/get/getting/
s/cloned/clone/ ?
Line 108: */
Line 109: @Test
Line 110: public void testOtherFieldsNotValidatedInImport() {
Line 111: ImportVmParameters parameters = createParameters();
--
To view, visit http://gerrit.ovirt.org/9619
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f04e067e8bce2c6cd1010f83a44809a3c8c464c
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
