Vered Volansky has posted comments on this change.
Change subject: core: ImportVm test cleanup: Use StringUtil.repeat
......................................................................
Patch Set 8: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
Line 98:
Line 99: /**
Line 100: * Checking that other fields in
Line 101: * {@link
org.ovirt.engine.core.common.businessentities.VmStatic.VmStatic}
Line 102: * aren't get validated in import or import as cloned.
/aren't/ain't. kidding. change to don't, while you're at it.
Line 103: */
Line 104: @Test
Line 105: public void testOtherFieldsNotValidatedInImport() {
Line 106: ImportVmParameters parameters = createParameters();
Line 103: */
Line 104: @Test
Line 105: public void testOtherFieldsNotValidatedInImport() {
Line 106: ImportVmParameters parameters = createParameters();
Line 107: String stringOf5000Chars = StringUtils.repeat("A",
BusinessEntitiesDefinitions.GENERAL_MAX_SIZE + 1);
Why is it "A" and not as the previous ones?
stringOf5000Chars - is it?
Line 108:
parameters.getVm().setUserDefinedProperties(stringOf5000Chars);
Line 109: parameters.setImportAsNewEntity(true);
Line 110: ImportVmCommand command = new ImportVmCommand(parameters);
Line 111: Set<ConstraintViolation<ImportVmParameters>> validate =
--
To view, visit http://gerrit.ovirt.org/9619
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f04e067e8bce2c6cd1010f83a44809a3c8c464c
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
