Allon Mureinik has posted comments on this change.
Change subject: core: OvfDataUpdater - removal of update/remove OVF vdsm calls
......................................................................
Patch Set 22: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 79: "auto_startup",
Line 80: "dedicated_vm_for_vds", "default_display_type",
"priority", "default_boot_sequence", "initrd_url",
Line 81: "kernel_url", "kernel_params", "migrationSupport",
"minAllocatedMem", "quotaId", "quotaName",
Line 82: "quotaEnforcementType", "cpuPinning",
Line 83: "vmPayload", "balloonEnabled",
"smartcardEnabled","deleteProtected","dbGeneration",
This should be part of the previous patch
Line 84: "images", // images list is relational entity - ignore
value changes
Line 85: "interfaces" // interfaces is relational entity -
ignore value changes
Line 86: });
Line 87: mUpdateVmsStatic.AddFields(
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java
Line 34: "vds_group_id", "num_of_monitors",
"allowConsoleReconnect", "usb_policy", "time_zone", "diskMap",
Line 35: "default_boot_sequence",
Line 36: "iso_path", "diskImageMap", "default_display_type",
"priority", "auto_startup", "is_stateless",
Line 37: "initrd_url", "kernel_url", "kernel_params", "images",
"interfaces", "quotaId", "quotaName",
Line 38: "quotaEnforcementType", "migrationSupport",
"dedicated_vm_for_vds", "smartcardEnabled", "dbGeneration", "deleteProtected"
This should be part of the previous patch
Line 39: });
Line 40: }
Line 41:
Line 42: public static void UpdateDisksFromDb(VmTemplate vmt) {
--
To view, visit http://gerrit.ovirt.org/9340
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedebceb9809dc0b11c0bbe8a2d4af63b0d848df1
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
