Maor Lipchuk has posted comments on this change.
Change subject: core: OvfDataUpdater - removal of update/remove OVF vdsm calls
......................................................................
Patch Set 25: Looks good to me, but someone else must approve
(1 inline comment)
Only minor comments.
I think that in the future we will need to add some kind of helper methods or
infrastructure that will make it more easy to use.
(For instance to remind all the time that the increment should only be before
the update of the entity when there is no transaction)
The change does improve the use of OVF update, so +1
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
Line 406: OvfDataUpdater.getInstance().loadVmData(getVm());
Line 407:
OvfDataUpdater.getInstance().buildMetadataDictionaryForVm(getVm(),
metaDictionary);
Line 408: VmHandler.updateDisksFromDb(getVm());
Line 409: return
OvfDataUpdater.getInstance().executeUpdateVmInSpmCommand(getVm().getStoragePoolId(),
Line 410: metaDictionary,getParameters().getStorageDomainId());
Please use formatter here
Line 411: }
Line 412:
Line 413: @Override
Line 414: protected void endSuccessfully() {
--
To view, visit http://gerrit.ovirt.org/9340
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedebceb9809dc0b11c0bbe8a2d4af63b0d848df1
Gerrit-PatchSet: 25
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
