Shireesh Anjal has posted comments on this change.
Change subject: engine: gluster action version check added
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java
Line 39: }
Line 40: }
Line 41:
Line 42: @Override
Line 43: public VdcReturnValueBase canDoActionOnly() {
I don't think it would. Because when internalCanDoAction() is called from
executeAction(), your code will not get executed, and hence getVdsGroup() will
return null inside isBackwardsCompatible(), and the check will not be performed.
Line 44: setClusterId();
Line 45: return super.canDoActionOnly();
Line 46: }
Line 47:
--
To view, visit http://gerrit.ovirt.org/9670
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12047a40a4ef81901ce3050f1d39abe0af746d55
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
