Omer Frenkel has posted comments on this change.
Change subject: engine: gluster action version check added
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java
Line 47: @Override
Line 48: protected boolean isBackwardsCompatible() {
Line 49: setClusterId();
Line 50: return super.isBackwardsCompatible();
Line 51: }
i really don't like messing the code like this,
i think there is an easy way to set this in the constructor,
and in the test class just provide a mock for getVdsGroupDAO
i am sure this is the way its done in other commands
Line 52:
Line 53: @Override
Line 54: protected boolean canDoAction() {
Line 55: if (getGlusterVolume() == null) {
--
To view, visit http://gerrit.ovirt.org/9670
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12047a40a4ef81901ce3050f1d39abe0af746d55
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
