Alissa Bonas has uploaded a new change for review. Change subject: core: cleanup and renaming in VdsDeploy ......................................................................
core: cleanup and renaming in VdsDeploy Remove unused constant, rename variable according to java convention and improve log message to be more clear. Change-Id: I09d8322c88bd4982c232fa8217532a541e24cc64 Signed-off-by: Alissa Bonas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java 1 file changed, 4 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/90/10290/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java index 04d13b2..23d4ab9 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java @@ -70,7 +70,6 @@ */ public class VdsDeploy implements SSHDialog.Sink { - private static final int BUFFER_SIZE = 10 * 1024; private static final int THREAD_JOIN_TIMEOUT = 20 * 1000; // milliseconds private static final String IPTABLES_CUSTOM_RULES_PLACE_HOLDER = "@CUSTOM_RULES@"; private static final String BOOTSTRAP_CUSTOM_ENVIRONMENT_PLACE_HOLDER = "@ENVIRONMENT@"; @@ -784,10 +783,10 @@ ); if (s_deployPackage == null) { - String cachedir = System.getenv("ENGINE_CACHE"); - if (cachedir == null) { - log.warn("ENGINE_CACHE environment not found using tmpdir"); - cachedir = System.getProperty("java.io.tmpdir"); + String cacheDir = System.getenv("ENGINE_CACHE"); + if (cacheDir == null) { + log.warn("ENGINE_CACHE environment variable not found, using tmpdir instead."); + cacheDir = System.getProperty("java.io.tmpdir"); } s_deployPackage = new CachedTar( new File( -- To view, visit http://gerrit.ovirt.org/10290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I09d8322c88bd4982c232fa8217532a541e24cc64 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
