Alon Bar-Lev has posted comments on this change.
Change subject: core: cleanup and renaming in VdsDeploy
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
Line 785: if (s_deployPackage == null) {
Line 786: String cacheDir = System.getenv("ENGINE_CACHE");
Line 787: if (cacheDir == null) {
Line 788: log.warn("ENGINE_CACHE environment variable not
found, using tmpdir instead.");
Line 789: cacheDir = System.getProperty("java.io.tmpdir");
Well, actually if you clean it up, you can remove the entire hang... as the
cacheDir is not used as far as I can see :)
It was replaced by the getCacheDir() bellow.
It was strange that rename ends up with assignment.
Line 790: }
Line 791: s_deployPackage = new CachedTar(
Line 792: new File(
Line 793: LocalConfig.getInstance().getCacheDir(),
--
To view, visit http://gerrit.ovirt.org/10290
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09d8322c88bd4982c232fa8217532a541e24cc64
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
