Omer Frenkel has posted comments on this change.
Change subject: Adding host bios fields to vds_dynamic table
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 131: select fn_db_add_config_value('NetworkLinkingSupported','true','3.2');
Line 132: select
fn_db_add_config_value('DisconnectPoolOnReconstruct','0,2','general');
Line 133: select
fn_db_add_config_value('HotPlugUnsupportedOsList','','general');
Line 134: select
fn_db_add_config_value('InitStorageSparseSizeInGB','1','general');
Line 135: select fn_db_add_config_value('BiosInfoEnabled','true','3.2');
i didnt understand Eli's comment, but i think this value is needed
and if you add value with version (as you do here),
you should have value for each version, as you did in the previous patch.
Line 136: --Handling Install virtualization software on Add Host
Line 137:
Line 138: select fn_db_add_config_value('InstallVds','true','general');
Line 139: select fn_db_add_config_value('IoOpTimeoutSec','10','general');
--
To view, visit http://gerrit.ovirt.org/10114
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id330288a13490475a61625eb0b6076153fec422f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
