Yair Zaslavsky has posted comments on this change.
Change subject: Adding host bios fields to vds_dynamic table
......................................................................
Patch Set 7: (1 inline comment)
Yaniv, please close about bios prefixes with Alon Bar Lev.
As you see - I asked Eli about his General vs per version comment.
Besides that - the patch does look good to me.
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 131: select fn_db_add_config_value('NetworkLinkingSupported','true','3.2');
Line 132: select
fn_db_add_config_value('DisconnectPoolOnReconstruct','0,2','general');
Line 133: select
fn_db_add_config_value('HotPlugUnsupportedOsList','','general');
Line 134: select
fn_db_add_config_value('InitStorageSparseSizeInGB','1','general');
Line 135: select fn_db_add_config_value('BiosInfoEnabled','false','3.0');
Eli - why?
What about NetworkLinkingSupported for example? same issue - did not exist in
3.0 and 3.1 - how will you work with hosts that are in 3.1 and 3.0 clusters?
Line 136: select fn_db_add_config_value('BiosInfoEnabled','false','3.1');
Line 137: select fn_db_add_config_value('BiosInfoEnabled','true','3.2');
Line 138: --Handling Install virtualization software on Add Host
Line 139:
--
To view, visit http://gerrit.ovirt.org/10114
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id330288a13490475a61625eb0b6076153fec422f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
