Liron Aravot has posted comments on this change. Change subject: core : BLL changes for Multi-Tier fencing ......................................................................
Patch Set 4: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java Line 293: Line 294: } Line 295: } Line 296: } Line 297: i suggest the make use here of this patch, will save some lines of code from here .. http://gerrit.ovirt.org/#/c/10354/ Line 298: private void runThread(CountDownLatch latch, VDSReturnValue value, FencingExecutor executor, FenceAgentOrder order, boolean succeeded) { Line 299: value = executor.Fence(order); Line 300: if (value.getSucceeded()) { Line 301: executor = new FencingExecutor(getVds(), FenceActionType.Status); Line 298: private void runThread(CountDownLatch latch, VDSReturnValue value, FencingExecutor executor, FenceAgentOrder order, boolean succeeded) { Line 299: value = executor.Fence(order); Line 300: if (value.getSucceeded()) { Line 301: executor = new FencingExecutor(getVds(), FenceActionType.Status); Line 302: succeeded = waitForStatus(getVds().getvds_name(), getParameters().getAction(), order); general : the countdown is better be in finally block to avoid any case in which we will wait forever Line 303: latch.countDown(); Line 304: } Line 305: } Line 306: private void handleWaitFailure(VDSStatus lastStatus) { -- To view, visit http://gerrit.ovirt.org/10260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82f243593f2b361ca75d97e06f9aede246d4a1b1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
