Liron Aravot has posted comments on this change.
Change subject: core : BLL changes for Multi-Tier fencing
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
Line 294: }
Line 295: }
Line 296: }
Line 297:
Line 298: private void runThread(CountDownLatch latch, VDSReturnValue
value, FencingExecutor executor, FenceAgentOrder order, boolean succeeded) {
just noticed that it's the runThread method that will run by few threads -
if it's indeed to change the member and few threads can, concurrency issues
should be handled as well ofcourse - sorry for the splitted comment
Line 299: value = executor.Fence(order);
Line 300: if (value.getSucceeded()) {
Line 301: try {
Line 302: executor = new FencingExecutor(getVds(),
FenceActionType.Status);
--
To view, visit http://gerrit.ovirt.org/10260
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82f243593f2b361ca75d97e06f9aede246d4a1b1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
