Shireesh Anjal has posted comments on this change. Change subject: engine: gluster action version check added ......................................................................
Patch Set 4: No score Ok. While your code sample won't work as is, I get what you are suggesting. Overriding getVdsGroupId() is definitely nicer than overriding isBackwardsCompatible(). I'm removing my +1; will wait for a new patch-set implementing Roy's suggestion. -- To view, visit http://gerrit.ovirt.org/9670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12047a40a4ef81901ce3050f1d39abe0af746d55 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Selvasundaram <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
