Roy Golan has posted comments on this change.
Change subject: engine: gluster action version check added
......................................................................
Patch Set 4:
1st agree about static mocking, forget it.
init() of any kind is a step forward for testing and treating our commands as
beans (PostConstruct like) but there is a WIP on DI which will solve this all
together (and ofcourse will make static mocking history)
I suggest simply
@override
Guid getVdsGroupId() {
if (getGlusterVolume() != null) {
setVdsGroupId(getGlusterVolume().getClusterId());
}
return Guid.Empty;
}
--
To view, visit http://gerrit.ovirt.org/9670
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12047a40a4ef81901ce3050f1d39abe0af746d55
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
