Mike Kolesnik has uploaded a new change for review. Change subject: engine: Refactor NetworkCommon ......................................................................
engine: Refactor NetworkCommon 1. Change inheritance to CommandBase since this is not a storage command, and seems that all it got from the storage command was permissions (which are explicit here anyways). 2. Change to abstract - no need for empty implementation of executeCommand. 3. Ignored serialization ID warning since this class not serialized anyway. Change-Id: I17590518c681f72c638188275ec75a651a9cf5ff Signed-off-by: Mike Kolesnik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java 1 file changed, 3 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/54/10454/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java index 5c2a75c..4e3a0d1 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java @@ -3,7 +3,7 @@ import java.util.Collections; import java.util.List; -import org.ovirt.engine.core.bll.storage.StorageHandlingCommandBase; +import org.ovirt.engine.core.bll.CommandBase; import org.ovirt.engine.core.bll.utils.PermissionSubject; import org.ovirt.engine.core.common.VdcObjectType; import org.ovirt.engine.core.common.action.AddNetworkStoragePoolParameters; @@ -11,7 +11,6 @@ import org.ovirt.engine.core.common.config.Config; import org.ovirt.engine.core.common.config.ConfigValues; import org.ovirt.engine.core.compat.Guid; -import org.ovirt.engine.core.compat.NotImplementedException; import org.ovirt.engine.core.compat.Version; import org.ovirt.engine.core.dal.VdcBllMessages; import org.ovirt.engine.core.dal.dbbroker.auditloghandling.CustomLogField; @@ -19,8 +18,9 @@ import org.ovirt.engine.core.utils.linq.LinqUtils; import org.ovirt.engine.core.utils.linq.Predicate; +@SuppressWarnings("serial") @CustomLogFields({ @CustomLogField("NetworkName") }) -public class NetworkCommon<T extends AddNetworkStoragePoolParameters> extends StorageHandlingCommandBase<T> { +public abstract class NetworkCommon<T extends AddNetworkStoragePoolParameters> extends CommandBase<T> { public NetworkCommon(T parameters) { super(parameters); this.setStoragePoolId(getParameters().getNetwork().getstorage_pool_id()); @@ -28,11 +28,6 @@ public String getNetworkName() { return getParameters().getNetwork().getname(); - } - - @Override - protected void executeCommand() { - throw new NotImplementedException(); } protected boolean validateVmNetwork() { -- To view, visit http://gerrit.ovirt.org/10454 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I17590518c681f72c638188275ec75a651a9cf5ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
