Moti Asayag has posted comments on this change.
Change subject: engine: Refactor NetworkCommon
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java
Line 90: return false;
Line 91: }
Line 92: }
Line 93: return true;
Line 94: }
just a note for a next patch in this series (not related to the current patch):
this should be replaced by a validation on Network.vlanId
Line 95:
Line 96: private boolean isVlanInRange(int vlanId) {
Line 97: return (vlanId >= 0 && vlanId <= 4095);
Line 98: }
--
To view, visit http://gerrit.ovirt.org/10454
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17590518c681f72c638188275ec75a651a9cf5ff
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
