Mike Kolesnik has uploaded a new change for review. Change subject: core: Delete OnPropertyChanged from entities ......................................................................
core: Delete OnPropertyChanged from entities This method was used in the C# code, it's unused and unhelpful, so deleting it from the entities & params where there's still trace of it. Change-Id: Icca53f05ddc99d8603641f36cf14246c71040dce Signed-off-by: Mike Kolesnik <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUserBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/bookmarks.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/event_subscriber.java 6 files changed, 0 insertions(+), 55 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/60/10460/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java index e333529..7dcae69 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java @@ -5,7 +5,6 @@ import org.ovirt.engine.core.common.users.VdcUser; import org.ovirt.engine.core.compat.Guid; import org.ovirt.engine.core.compat.INotifyPropertyChanged; -import org.ovirt.engine.core.compat.PropertyChangedEventArgs; public class RunVmParams extends VmOperationParameterBase implements INotifyPropertyChanged { private static final long serialVersionUID = 3311307677963231320L; @@ -151,7 +150,6 @@ public void setWin2kHackEnable(Boolean value) { _win2kHackEnable = value; - OnPropertyChanged(new PropertyChangedEventArgs("Win2kHackEnable")); } public String getClientIp() { @@ -184,9 +182,6 @@ public void setRunAsStateless(Boolean value) { privateRunAsStateless = value; - } - - protected void OnPropertyChanged(PropertyChangedEventArgs e) { } public String getinitrd_url() { diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java index 01168c9..a4a2c5c 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java @@ -15,7 +15,6 @@ import org.hibernate.annotations.TypeDef; import org.ovirt.engine.core.common.businessentities.mapping.GuidType; import org.ovirt.engine.core.compat.Guid; -import org.ovirt.engine.core.compat.PropertyChangedEventArgs; import org.ovirt.engine.core.compat.StringHelper; @Entity @@ -278,7 +277,6 @@ public void setgroups(String value) { this.groups = value; - OnPropertyChanged(new PropertyChangedEventArgs("groups")); } public String getname() { @@ -288,7 +286,6 @@ public void setname(String value) { if (!StringHelper.EqOp(this.name, value)) { this.name = value; - OnPropertyChanged(new PropertyChangedEventArgs("name")); } } @@ -322,7 +319,6 @@ public void setsurname(String value) { this.surname = value; - OnPropertyChanged(new PropertyChangedEventArgs("surname")); } public String getuser_icon_path() { @@ -347,7 +343,6 @@ public void setusername(String value) { this.username = value; - OnPropertyChanged(new PropertyChangedEventArgs("username")); } public int getsession_count() { @@ -356,7 +351,6 @@ public void setsession_count(int value) { sessionCount = value; - OnPropertyChanged(new PropertyChangedEventArgs("session_count")); setIsLogedin((sessionCount > 0)); } @@ -366,7 +360,6 @@ public void setIsLogedin(boolean value) { isLoggedIn = value; - OnPropertyChanged(new PropertyChangedEventArgs("IsLogedin")); } public DbUser(AdUser adUser) { diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUserBase.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUserBase.java index 6e0fb5e..30cd3a4 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUserBase.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUserBase.java @@ -3,13 +3,9 @@ import java.io.Serializable; import org.ovirt.engine.core.compat.INotifyPropertyChanged; -import org.ovirt.engine.core.compat.PropertyChangedEventArgs; public class DbUserBase extends IVdcQueryable implements INotifyPropertyChanged, Serializable { private static final long serialVersionUID = 7161103320297970617L; - - protected void OnPropertyChanged(PropertyChangedEventArgs e) { - } public DbUserBase() { } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java index f8aa933..0d05faf 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java @@ -17,7 +17,6 @@ import org.ovirt.engine.core.common.validation.group.UpdateEntity; import org.ovirt.engine.core.compat.Guid; import org.ovirt.engine.core.compat.INotifyPropertyChanged; -import org.ovirt.engine.core.compat.PropertyChangedEventArgs; @Entity @Table(name = "roles") @@ -125,17 +124,14 @@ public void setdescription(String value) { this.description = value; - OnPropertyChanged(new PropertyChangedEventArgs("description")); } public void setis_readonly(boolean value) { this.readOnly = value; - OnPropertyChanged(new PropertyChangedEventArgs("is_readonly")); } public void setname(String value) { this.name = value; - OnPropertyChanged(new PropertyChangedEventArgs("name")); } public void setType(RoleType type) { @@ -144,13 +140,6 @@ public RoleType getType() { return type; - } - - // TODO -This method and its reference code are being tested with the GWT - // UI. - // Remove this only when its surely not needed by them. - protected void OnPropertyChanged(@SuppressWarnings("unused") PropertyChangedEventArgs e) { - // purposely empty } @Override diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/bookmarks.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/bookmarks.java index 3364f71..39a45ff 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/bookmarks.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/bookmarks.java @@ -16,7 +16,6 @@ import org.ovirt.engine.core.common.businessentities.mapping.GuidType; import org.ovirt.engine.core.compat.Guid; import org.ovirt.engine.core.compat.INotifyPropertyChanged; -import org.ovirt.engine.core.compat.PropertyChangedEventArgs; @Entity @Table(name = "bookmarks") @@ -52,15 +51,11 @@ public void setbookmark_value(String value) { this.value = value; - OnPropertyChanged(new PropertyChangedEventArgs("bookmark_value")); - } public void setbookmark_name(String name) { this.name = name; - OnPropertyChanged(new PropertyChangedEventArgs("bookmark_name")); - } @@ -114,14 +109,5 @@ @Override public Object getQueryableId() { return getbookmark_id(); - } - - // public event PropertyChangedEventHandler PropertyChanged; - - protected void OnPropertyChanged(PropertyChangedEventArgs e) { - /* if (PropertyChanged != null) */ - { - /* PropertyChanged(this, e); */ - } } } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/event_subscriber.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/event_subscriber.java index 6582794..ccbe6fd 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/event_subscriber.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/event_subscriber.java @@ -14,7 +14,6 @@ import org.ovirt.engine.core.common.businessentities.mapping.GuidType; import org.ovirt.engine.core.compat.Guid; import org.ovirt.engine.core.compat.INotifyPropertyChanged; -import org.ovirt.engine.core.compat.PropertyChangedEventArgs; import org.ovirt.engine.core.compat.StringFormat; @Entity @@ -113,7 +112,6 @@ public void setevent_up_name(String value) { this.id.eventUpName = value; - OnPropertyChanged(new PropertyChangedEventArgs("event_up_name")); } public int getmethod_id() { @@ -122,7 +120,6 @@ public void setmethod_id(int value) { this.id.methodId = value; - OnPropertyChanged(new PropertyChangedEventArgs("method_id")); } @Column(name = "method_address", length = 255) @@ -135,7 +132,6 @@ public void setmethod_address(String value) { this.methodAddress = value; - OnPropertyChanged(new PropertyChangedEventArgs("method_address")); } public Guid getsubscriber_id() { @@ -144,7 +140,6 @@ public void setsubscriber_id(Guid value) { this.id.subscriberId = value; - OnPropertyChanged(new PropertyChangedEventArgs("subscriber_id")); } public String gettag_name() { @@ -153,7 +148,6 @@ public void settag_name(String value) { this.id.tagName = value; - OnPropertyChanged(new PropertyChangedEventArgs("tag_name")); } // if there will be subscribers edit we should add unique field to this @@ -163,12 +157,4 @@ return StringFormat.format("%1$s%2$s%3$s%4$s", id.eventUpName, id.methodId, id.subscriberId, id.tagName == null ? "" : id.tagName); } - - protected void OnPropertyChanged(PropertyChangedEventArgs e) { - /* if (PropertyChanged != null) */ - { - /* PropertyChanged(this, e); */ - } - } - } -- To view, visit http://gerrit.ovirt.org/10460 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icca53f05ddc99d8603641f36cf14246c71040dce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
