Michael Pasternak has posted comments on this change.
Change subject: resapi: adding support for moving a VM disk
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java
Line 80: public Response move(Action action) {
Line 81: validateParameters(action, "storageDomain.id|name");
Line 82: MoveDisksParameters params =
Line 83: new MoveDisksParameters(Collections.singletonList(new
MoveDiskParameters(
Line 84: asGuid(get().getImageId()),
somehow i was sure image_id=disk.id, anyway using get() in this context is
incorrect as it has api mapping/relation discovering round-trips,
just use query instead,
also some disks does not have ImageId, are you sure MoveDisks can handle,
ImageId=NULL?
Line 85: Guid.Empty,
Line 86: getStorageDomainId(action))));
Line 87: return doAction(VdcActionType.MoveDisks, params, action);
Line 88: }
--
To view, visit http://gerrit.ovirt.org/10676
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c864a81463388f8ac82eba6f909c5a4359efab6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
