Michael Pasternak has posted comments on this change.
Change subject: restapi: adding support for moving a VM disk
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
well done Daniel,
i have only two comment on tests that will become clear to you if you'll review
my reply for Iefef71e2 first.
thanks.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java
Line 610:
setUpEntityQueryExpectations(VdcQueryType.GetAllStorageDomains,
Line 611: VdcQueryParametersBase.class,
Line 612: new String[] {},
Line 613: new Object[] {},
Line 614: Collections.singletonList(getStorageDomain(2)));
please have here two tests, one for admin using search (old code) and one for
non-admin using VdcQueryType.GetAllStorageDomains (new code), but note that you
have to setup filter=true header expectation for it.
Line 615:
Line 616: StorageDomain storageDomain = new StorageDomain();
Line 617: storageDomain.setName(NAMES[2]);
Line 618:
Line 668:
setUpEntityQueryExpectations(VdcQueryType.GetAllStorageDomains,
Line 669: VdcQueryParametersBase.class,
Line 670: new String[] {},
Line 671: new Object[] {},
Line 672: Collections.singletonList(getStorageDomain(2)));
please have here two tests, one for admin using search (old code) and one for
non-admin using VdcQueryType.GetAllStorageDomains (new code), but note that you
have to setup filter=true header expectation for it.
Line 673:
Line 674: StorageDomain storageDomain = new StorageDomain();
Line 675: storageDomain.setName(NAMES[2]);
Line 676:
--
To view, visit http://gerrit.ovirt.org/10676
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c864a81463388f8ac82eba6f909c5a4359efab6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
