Dhandapani Gopal has posted comments on this change.
Change subject: engine: Fix SHD service not displaying issue (#885592)
......................................................................
Patch Set 4: (2 inline comments)
Incorporated review comments. New patch set to follow.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java
Line 106: getParameters().isDetailRequired()));
Line 107: return returnValue;
Line 108: }
Line 109:
Line 110: private String getReplicateVolumeName(Guid clusterId) {
Done
Line 111: String volumeName = "";
Line 112: List<GlusterVolumeEntity> replicateVolumes =
getReplicateVolumes(clusterId, getReplicateVolumeTypeNames());
Line 113: if (replicateVolumes.size() > 0) {
Line 114: volumeName = replicateVolumes.get(0).getName();
Line 115: }
Line 116: return volumeName;
Line 117: }
Line 118:
Line 119: private List<GlusterVolumeType> getReplicateVolumeTypeNames() {
Changed the method name to getReplicateVolumeTypes()
Line 120: List<GlusterVolumeType> volumeTypes = new
ArrayList<GlusterVolumeType>();
Line 121: volumeTypes.add(GlusterVolumeType.REPLICATE);
Line 122: volumeTypes.add(GlusterVolumeType.DISTRIBUTED_REPLICATE);
Line 123: return volumeTypes;
--
To view, visit http://gerrit.ovirt.org/10336
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id11725f44ab3fdd36f76fe569d7610a411518ee1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
