Roy Golan has posted comments on this change.
Change subject: core: Replace ImagesHandler#isVmDown method
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
Line 1530: *
Line 1531: * @return true if the VM's status is DOWN, otherwise false
Line 1532: */
Line 1533: public boolean isDown() {
Line 1534: return getStatus() == VMStatus.Down;
I don't think we need to pollute our entities with helper methods and your
VMStatus patch is really about this.
and its actually less readable this was as well -
if (xxx || vm.getStatus() == VMStatus.Down)
is really simpler, stupid and cleaner.
Line 1535: }
--
To view, visit http://gerrit.ovirt.org/10779
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f15c8b9a307d5ecb239750dbdbac3faea7b802a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
