Omer Frenkel has submitted this change and it was merged. Change subject: core: Replace ImagesHandler#isVmDown method ......................................................................
core: Replace ImagesHandler#isVmDown method Replace ImagesHandler#isVmDown method with VM#isDown method. ImagesHander is not the place for utility method that checks VM status. VM status is a property of VM, thus VM instance should be able to express whether it's down or not, passing a VM instance to another class in order to check its status doesn't make sense. Change-Id: I3f15c8b9a307d5ecb239750dbdbac3faea7b802a Signed-off-by: Arik Hadas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java 3 files changed, 13 insertions(+), 9 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/10779 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f15c8b9a307d5ecb239750dbdbac3faea7b802a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
