Alissa Bonas has uploaded a new change for review. Change subject: core: Fix logging level in several classes ......................................................................
core: Fix logging level in several classes Log exceptions in error instead of debug Log frequent actions in debug instead of info Make log message in CheckDBConnectionQuery more clear Change-Id: Ia9113da6efef848b6da927902268fea579b83bfd Signed-off-by: Alissa Bonas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CheckDBConnectionQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java 4 files changed, 6 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/82/10882/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java index 86cb22b..ba3e848 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java @@ -80,7 +80,6 @@ * @param actionType autorecovery action * @param paramsCallback a closure to create the parameters for the autorecovery action * @param logMsg a user-readable name for the failing resource type - * @param counters counters for the failing resources to avoid too frequent auditlog */ <T extends BusinessEntity<Guid>> void check(final AutoRecoverDAO<T> dao, final VdcActionType actionType, @@ -90,7 +89,7 @@ log.info("Autorecovering " + logMsg + " is disabled, skipping"); return; } - log.info("Checking autorecoverable " + logMsg); + log.debug("Checking autorecoverable " + logMsg); final List<T> fails = dao.listFailedAutorecoverables(); final BackendInternal backend = getBackend(); log.info("Autorecovering " + fails.size() + " " + logMsg); @@ -100,7 +99,7 @@ actionParams.setShouldBeLogged(true); backend.runInternalAction(actionType, actionParams); } - log.info("Checking autorecoverable " + logMsg + " done"); + log.debug("Checking autorecoverable " + logMsg + " done"); } protected DbFacade getDbFacade() { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CheckDBConnectionQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CheckDBConnectionQuery.java index a5be1fd..1fc1b3d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CheckDBConnectionQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CheckDBConnectionQuery.java @@ -10,8 +10,8 @@ @Override protected void executeQueryCommand() { - log.debug("Calling DB test..."); + log.debug("Start checking connection to db"); getQueryReturnValue().setReturnValue(getDbFacade().CheckDBConnection()); - log.debug("DB test ended."); + log.debug("Completed checking connection to db"); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java index 9b120f7..c7dff96 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java @@ -1337,7 +1337,7 @@ rollbackQuota(); } } catch (NullPointerException e) { - log.debug("RollbackQuota: failed (may be because quota is disabled)", e); + log.error("RollbackQuota: failed (may be because quota is disabled)", e); } cancelTasks(); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java index 85cb553..1f201dd 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java @@ -205,7 +205,7 @@ // we will want this info VdcUser currentUser = new VdcUser(ldapUser); boolean isAdmin = MultiLevelAdministrationHandler.isAdminUser(currentUser); - log.infoFormat("Checking if user {0} is an admin, result {1}", currentUser.getUserName(), isAdmin); + log.debugFormat("Checking if user {0} is an admin, result {1}", currentUser.getUserName(), isAdmin); currentUser.setAdmin(isAdmin); setCurrentUser(currentUser); } -- To view, visit http://gerrit.ovirt.org/10882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia9113da6efef848b6da927902268fea579b83bfd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
