Alissa Bonas has posted comments on this change.
Change subject: core: Fix logging level in several classes
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java
Line 98: final VdcActionParametersBase actionParams =
paramsCallback.doWith(fail);
Line 99: actionParams.setShouldBeLogged(true);
Line 100: backend.runInternalAction(actionType, actionParams);
Line 101: }
Line 102: log.debug("Checking autorecoverable " + logMsg + " done");
yes.
rethinking the whole thing - isDebugEnabled best to come in calling code, not
in the wrapper (see my mail regarding my other patch related to the subject)
Line 103: }
Line 104:
Line 105: protected DbFacade getDbFacade() {
Line 106: return DbFacade.getInstance();
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1336: if (isQuotaDependant()) {
Line 1337: rollbackQuota();
Line 1338: }
Line 1339: } catch (NullPointerException e) {
Line 1340: log.error("RollbackQuota: failed (may be because quota
is disabled)", e);
not a pretty sight, I completely agree...
Line 1341: }
Line 1342: cancelTasks();
Line 1343: }
Line 1344:
--
To view, visit http://gerrit.ovirt.org/10882
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9113da6efef848b6da927902268fea579b83bfd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
