Daniel Erez has posted comments on this change.
Change subject: webadmin: disk search overridden by default upon tab reveal
......................................................................
Patch Set 1:
The radio buttons in disks main tab are merely for filtering the search string.
Instead of the new "Search Results" introduced in the patch,
the issues described in the bug can be resolved just by modifying the search
string
manipulation logic in MainTabDiskView -> searchByDiskViewType().
E.g. adding a condition for handling the case (and possibly a few more
tweaks...):
if (!commonModel.getSearchString().isEmpty() &&
searchStringPrefixRaw.isEmpty()) {
int indexOfColon = commonModel.getSearchString().indexOf(":");
searchStringPrefix = commonModel.getSearchString().substring(0,
indexOfColon + 1);
searchString = commonModel.getSearchString().substring(indexOfColon + 1);
}
--
To view, visit http://gerrit.ovirt.org/10897
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebf63fc5e6343819062959cd85219b1a965daf95
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
