Greg Padgett has posted comments on this change.

Change subject: webadmin: disk search overridden by default upon tab reveal
......................................................................


Patch Set 2:

Thanks Daniel, I didn't realize the buttons were for filtering rather than 
searching.

I used your example and made some further changes to make sure it would filter 
properly whether the disk_type was specified in the searchStringPrefix or 
searchStringItself, would preserve other search clauses, and then build a 
human-readable string with the results.

Probably should be verified on IE, I have only tested on FF 17 and Chrome 23 so 
I won't yet tick the verified flag.

--
To view, visit http://gerrit.ovirt.org/10897
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iebf63fc5e6343819062959cd85219b1a965daf95
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to