Asaf Shakarchi has uploaded a new change for review. Change subject: engine: Changed Event.equal signature to override Object.equal ......................................................................
engine: Changed Event.equal signature to override Object.equal Changed the covariant version of the Event.equals(Event other) to override standard java Object.equals(Object other). Change-Id: Idca42d6a61454162db412429e55898f15152c12d Signed-off-by: Asaf Shakarchi <[email protected]> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Event.java 1 file changed, 14 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/55/10955/1 diff --git a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Event.java b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Event.java index ce6a15e..8323a0e 100644 --- a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Event.java +++ b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Event.java @@ -99,12 +99,22 @@ } } - public boolean equals(Event other) { - if(other == null){ + @Override + public boolean equals(Object other) { + if (other == null) { return false; } - return StringHelper.stringsEqual(getName(), other.getName()) - && getOwnerType() == other.getOwnerType(); + + if (other == this) { + return true; + } + + if (!(other instanceof Event)) { + return false; + } + + return StringHelper.stringsEqual(getName(), ((Event) other).getName()) + && getOwnerType() == ((Event) other).getOwnerType(); } public boolean equals(EventDefinition other) { -- To view, visit http://gerrit.ovirt.org/10955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idca42d6a61454162db412429e55898f15152c12d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
