Asaf Shakarchi has posted comments on this change. Change subject: engine: Changed Event.equal signature to override Object.equal ......................................................................
Patch Set 1: Moty/Allon, great review, thanks. The equality comparison you've mentioned are problematic even with the current state, So here's a summary of the modifications: 1) Rename equals(EventDefinition e)) to matchesDefinition(EventDefinitione)). 2) Replace the current equals code by a new identity equality [can be generated by eclipse] based on the Name & Owner type. 3) Generate an appropriate identity based hashCode implementation Please ack before I do the changes as it requires refactoring (Event:equals(EventDefinition)) is invoked everywhere. -- To view, visit http://gerrit.ovirt.org/10955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idca42d6a61454162db412429e55898f15152c12d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
