Sharad Mishra has posted comments on this change. Change subject: core: WIP: Add suppoort for SSL in LDAP. ......................................................................
Patch Set 1: Thanks Alon for your comments and review. Yes, this is a partial patch and hence I marked it as WIP. This does not address the CLI. As I had mentioned in the email thread on engine-devel, we need to update that and pass more parameters to engine-manage-domain. My first reaction was to keep authentication and protocol separate. But I took an easier approach :-) I will take a second look at it. The code snippet that you had emailed on engine-devel did not make much sense in this case. I looked at it when you first emailed, may be it needs a second look too :-) -- To view, visit http://gerrit.ovirt.org/10898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31acf3142ca8cffe8f9174545ee8421ec243644a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
