Alon Bar-Lev has posted comments on this change.

Change subject: packaging: Updated cleanup to clean  postgresql 9.2 connections
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File packaging/fedora/setup/common_utils.py
Line 1030:     # Disconnect active connections
Line 1031:     # First, check psql version, as this would work differently for 
9.2
Line 1032:     logging.info("Checking PostgreSQL version")
Line 1033:     pid = "procpid"
Line 1034:     if getRpmVersion("postgresql").startswith("9.2"):
Please don't.

Please use: /usr/bin/postgres --version
Line 1035:         logging.info("Detected PostgreSQL version 9.2")
Line 1036:         pid = "pid"
Line 1037: 
Line 1038:     logging.info("Disconnect active connections from DB '%s'" % 
dbName)


--
To view, visit http://gerrit.ovirt.org/10389
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfad6d478a647ee91d818f1f377490a29a1a2ddb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to