Alon Bar-Lev has posted comments on this change.

Change subject: packaging: Updated cleanup to clean  postgresql 9.2 connections
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File packaging/fedora/setup/common_utils.py
Line 1043:             "-c", version_query,
Line 1044:         ]
Line 1045:     out, rc = execCmd(cmdList=cmd, failOnError=True, 
msg=output_messages.ERR_POSTGRESQL, envDict=getPgPassEnv())
Line 1046:     version = out.split()[1]
Line 1047:     if version.startswith("9.2"):
should be >= 9.2 no?
Line 1048:         logging.info("Detected PostgreSQL version 9.2")
Line 1049:         pid = "pid"
Line 1050: 
Line 1051:     logging.info("Disconnect active connections from DB '%s'" % 
dbName)


--
To view, visit http://gerrit.ovirt.org/10389
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfad6d478a647ee91d818f1f377490a29a1a2ddb
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to