Itamar Heim has posted comments on this change.
Change subject: Verify vdsm cluster level support before send getHardwareInfo
request
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 513: if (vdsBrokerCommand.getVDSReturnValue().getSucceeded()) {
Line 514: // Verify version capabilities
Line 515: if (Config.<Boolean>
GetValue(ConfigValues.HardwareInfoEnabled,
vds.getvds_group_compatibility_version()
Line 516: .getValue()) &&
Line 517: Config.<Boolean>
GetValue(ConfigValues.HardwareInfoEnabled, vds.getsupported_cluster_levels())) {
how will this work? getsupported_cluster
_levels returns a list of supported cluster levels?
Line 518: VDSReturnValue ret =
ResourceManager.getInstance().runVdsCommand(VDSCommandType.GetHardwareInfo,
Line 519: new VdsIdAndVdsVDSCommandParametersBase(vds));
Line 520: if (!ret.getSucceeded()) {
Line 521: AuditLogableBase logable = new
AuditLogableBase(vds.getId());
--
To view, visit http://gerrit.ovirt.org/11027
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I240786444bdf393f6df4e53daf94d0ee197ecb73
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
