Yair Zaslavsky has posted comments on this change.
Change subject: Verify vdsm cluster level support before send getHardwareInfo
request
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 515: if (vdsBrokerCommand.getVDSReturnValue().getSucceeded()) {
Line 516: // Verify version capabilities
Line 517: Version clusterCompatibility =
vds.getvds_group_compatibility_version();
Line 518: if (FeatureSupported.hardwareInfo(clusterCompatibility) &&
Line 519: // If the feature is enabled in cluster level, we
continue by verifying that VDS also supports the
s/that/this
Line 520: // specific cluster level. The request for hardware
info should be only called for hosts that support
Line 521: // that feature, otherwise that API won't be exist
and exception will be raised by vdsm.
Line 522:
vds.getSupportedClusterVersionsSet().contains(clusterCompatibility)) {
Line 523: VDSReturnValue ret =
ResourceManager.getInstance().runVdsCommand(VDSCommandType.GetHardwareInfo,
Line 516: // Verify version capabilities
Line 517: Version clusterCompatibility =
vds.getvds_group_compatibility_version();
Line 518: if (FeatureSupported.hardwareInfo(clusterCompatibility) &&
Line 519: // If the feature is enabled in cluster level, we
continue by verifying that VDS also supports the
Line 520: // specific cluster level. The request for hardware
info should be only called for hosts that support
s/won't be exist/won't exist for the host
Line 521: // that feature, otherwise that API won't be exist
and exception will be raised by vdsm.
Line 522:
vds.getSupportedClusterVersionsSet().contains(clusterCompatibility)) {
Line 523: VDSReturnValue ret =
ResourceManager.getInstance().runVdsCommand(VDSCommandType.GetHardwareInfo,
Line 524: new VdsIdAndVdsVDSCommandParametersBase(vds));
Line 517: Version clusterCompatibility =
vds.getvds_group_compatibility_version();
Line 518: if (FeatureSupported.hardwareInfo(clusterCompatibility) &&
Line 519: // If the feature is enabled in cluster level, we
continue by verifying that VDS also supports the
Line 520: // specific cluster level. The request for hardware
info should be only called for hosts that support
Line 521: // that feature, otherwise that API won't be exist
and exception will be raised by vdsm.
s/and exception/and an exception
Line 522:
vds.getSupportedClusterVersionsSet().contains(clusterCompatibility)) {
Line 523: VDSReturnValue ret =
ResourceManager.getInstance().runVdsCommand(VDSCommandType.GetHardwareInfo,
Line 524: new VdsIdAndVdsVDSCommandParametersBase(vds));
Line 525: if (!ret.getSucceeded()) {
--
To view, visit http://gerrit.ovirt.org/11027
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I240786444bdf393f6df4e53daf94d0ee197ecb73
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
