Shireesh Anjal has posted comments on this change.
Change subject: gluster: GlusterMultipleActionRunner
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunnersFactory.java
Line 70: }
Line 71: return runner;
Line 72: }
Line 73:
Line 74: private static boolean
containsGlusterServer(ArrayList<VdcActionParametersBase> parameters) {
Ah, and the other cast is not allowed i.e. one can't cast
ArrayList<VdcActionParameters> to ArrayList<VdsActionParameters>
So this is ruled out.
Line 75: Set<Guid> processed = new HashSet<Guid>();
Line 76: for(VdcActionParametersBase param : parameters) {
Line 77: VDS vds =
DbFacade.getInstance().getVdsDao().get(((RemoveVdsParameters)
param).getVdsId());
Line 78: if (!processed.contains(vds.getvds_group_id())) {
--
To view, visit http://gerrit.ovirt.org/10812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e3dc1fa0b21ab6e0fcaff518bf9696f6c9796ca
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
