Michael Kublin has posted comments on this change.
Change subject: gluster: GlusterMultipleActionRunner
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunnersFactory.java
Line 46: case StopGlusterVolume:
Line 47: case DeleteGlusterVolume:
Line 48: case SetGlusterVolumeOption:
Line 49: case ResetGlusterVolumeOptions:
Line 50: case AddVds: // AddVds is called with multiple actions *only*
in case of gluster clusters
AddVds is not acquired any lock. The lock is acquired at AddVdsSpmId which is
called from execute of AddVds
Line 51: case RemoveGlusterServer: {
Line 52: runner = new GlusterMultipleActionsRunner(actionType,
parameters, isInternal);
Line 53: break;
Line 54: }
Line 51: case RemoveGlusterServer: {
Line 52: runner = new GlusterMultipleActionsRunner(actionType,
parameters, isInternal);
Line 53: break;
Line 54: }
Line 55:
RemoveVds also takes a lock only on vds level, so I don't think that it should
be here
Line 56: case RemoveVds: {
Line 57: if(containsGlusterServer(parameters)) {
Line 58: runner = new GlusterMultipleActionsRunner(actionType,
parameters, isInternal);
Line 59: } else {
--
To view, visit http://gerrit.ovirt.org/10812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e3dc1fa0b21ab6e0fcaff518bf9696f6c9796ca
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
