Maor Lipchuk has uploaded a new change for review. Change subject: core: Add validation for DC's compatability. ......................................................................
core: Add validation for DC's compatability. Move storage pool validation for DC before fetching the disks when creating a snapshot. Since VM without snapshots will not get to this validation. Change-Id: I77e301643b3ac9789cc5eb7527b6a5a4a0aac6be Related-to: https://bugzilla.redhat.com/888862 Signed-off-by: Maor Lipchuk <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/07/11107/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java index 5e1f875..d5c000e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java @@ -282,13 +282,15 @@ @Override protected boolean canDoAction() { boolean result = true; + if (canDoSnapshot(getVm())) { + return false; + } List<DiskImage> disksList = getDisksList(); if (disksList.size() > 0) { VmValidator vmValidator = new VmValidator(getVm()); result = validate(new SnapshotsValidator().vmNotDuringSnapshot(getVmId())) && validate(vmValidator.vmNotDuringMigration()) && validate(vmValidator.vmNotRunningStateless()) - && canDoSnapshot(getVm()) && ImagesHandler.PerformImagesChecks(getVm(), getReturnValue().getCanDoActionMessages(), getVm().getStoragePoolId(), -- To view, visit http://gerrit.ovirt.org/11107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I77e301643b3ac9789cc5eb7527b6a5a4a0aac6be Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
