Liron Aravot has posted comments on this change.
Change subject: core: Add validation for DC's compatability.
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 283: protected boolean canDoAction() {
Line 284: boolean result = true;
Line 285: if (!canDoSnapshot(getVm())) {
Line 286: return false;
Line 287: }
you can also declare result only after performing this check
Line 288: List<DiskImage> disksList = getDisksList();
Line 289: if (disksList.size() > 0) {
Line 290: VmValidator vmValidator = new VmValidator(getVm());
Line 291: result = validate(new
SnapshotsValidator().vmNotDuringSnapshot(getVmId()))
--
To view, visit http://gerrit.ovirt.org/11107
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77e301643b3ac9789cc5eb7527b6a5a4a0aac6be
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
