Allon Mureinik has posted comments on this change.
Change subject: core: RemoveSnapshot vmDown validation
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
Line 162: initializeObjectState();
Line 163:
Line 164: if (!validateVmNotDuringSnapshot() ||
Line 165: !validateSnapshotExists() ||
Line 166: !validate(new VmValidator(getVm()).vmDown()) ||
yup - short circuit validation will ensure no performance degradation.
Line 167: !validateImagesAndVMStates()) {
Line 168: handleCanDoActionFailure();
Line 169: return false;
Line 170: }
--
To view, visit http://gerrit.ovirt.org/11014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd281aa6778a3249162517499b5f0f48b04ed6b6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
