Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveSnapshot vmDown validation ......................................................................
core: RemoveSnapshot vmDown validation Added an explicit test for VM.isDown in RemoveSnapshotCommand.canDoAction() instead of using ImagesHandler.PerformImagesChecks to do it. In order to do this neatly, such a method was added to VmValidator, which is the standard way of writing canDoActions. Note: This patch is part of a series intended to remove the VM status check from ImagesHandler. Change-Id: Ifd281aa6778a3249162517499b5f0f48b04ed6b6 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java 3 files changed, 39 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd281aa6778a3249162517499b5f0f48b04ed6b6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
