Alon Bar-Lev has posted comments on this change.

Change subject: webadmin: [WIP,improvment] expose simple config values access
......................................................................


Patch Set 2:

I do not understand a single line of code... but it is strange that we have 
only getBoolean, no?

I also don't quite understand why there was a need for a callback for 
starters... the whole configuration could have been loaded to ui, and reloaded 
only when a reloaded at backend side.

--
To view, visit http://gerrit.ovirt.org/11141
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2712ed87474577b8d0ff5d57bca9e120dc075981
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to